Skip to content

SQLiteAdapter::getPhinxType does not recognize types with whitespace in definition, e.g. DECIMAL(10, 5) #2319

Description

@InvisibleSmiley

Recognized: DECIMAL(10,5)
Rejected: DECIMAL(10, 5)

This is unfortunate since e.g. PhpStorm autoformatting inserts the space in a file where the SQL Dialect is set to SQLite. If a database is initialized with such a file, Phinx then struggles to apply migrations on top of that.

The fix should be simple: Allow optional spaces/whitespace in the regex contained in getPhinxType.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions