Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bitkeks/python-netflow-v9-softflowd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: release
Choose a base ref
...
head repository: bitkeks/python-netflow-v9-softflowd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature/ipfix-padding
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 3 contributors

Commits on Jul 2, 2022

  1. IPFIX: handle padding (zero bytes) in sets

    Adds a check to each IPFIX set ID branch, checking if the rest of the
    bytes in this set is padding/zeroes.
    
    Refs #34
    bitkeks committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    3c4f8e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Reverted changes to template_record, data_length is now computed usin…

    …g field length in template.
    
    Signed-off-by: Khaw Teng Kang <tk.khaw@attrelogix.com>
    Khaw Teng Kang authored and bitkeks committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    9d3c413 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51ce4ea View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. Finish IPFIX padding handling

    Tested implementation of IPFIX set padding handling. Uses TK-Khaw's
    proposed no_padding_last_offset calculation, extended as modulo
    calculation to match multiple data set records.
    
    Tests were conducted by capturing live traffic on a test machine with
    tcpdump, then this capture file was read in by softflowd 1.1.0, with the
    collector.py as the export target. The exported IPFIX (v10) packets were
    then using both no padding and padding, so that tests could be
    validated.
    
    Closes #34
    
    Signed-off-by: Dominik Pataky <software+pynetflow@dpataky.eu>
    bitkeks committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    8d1cf9c View commit details
    Browse the repository at this point in the history
  2. Padding: add offset!=length check to reduce safety check calls

    Adds another check when parsing a set. The check "offset !=
    self.header.length" allows to skip the padding checks if the offset is
    the same as the length, not calling rest_is_padding_zeroes and wasting
    CPU time.
    bitkeks committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    63abf52 View commit details
    Browse the repository at this point in the history
Loading