Skip to content

AtomContactSet uses Pair<Atom> which is directed (atom1 -> atom2) #1153

Description

@aalhossary

Atom contacts are saved in AtomContactSet as a Pair without enforcing atom ordering.
This way, a Contact c1 (atom1, atom2) is not considered equal to another Contact c2(atom2, atom1).

The fix is to ensure atom ordering as described in this comment.
However, this fix will impose behaviour change, which needs to be studied thoroughly first.

Originally posted by @aalhossary in #1147 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions