feat: support for NotFoundComponent design state is optional - #1013
Merged
Merged
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 72.64% | 879/1210 |
| 🟡 | Branches | 61.98% | 551/889 |
| 🟡 | Functions | 68.95% | 191/277 |
| 🟡 | Lines | 72.67% | 864/1189 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟡 | renderer/base.tsx | 67.45% | 55.4% | 64.2% | 67.46% |
| 🟡 | ... / renderer.tsx |
68.49% (-3.13% 🔻) |
40.32% (-5.97% 🔻) |
52.38% | 68.49% (-3.13% 🔻) |
Test suite run success
91 tests passing in 8 suites.
Report generated by 🧪jest coverage report action from b9fe1ad
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 33.33% (+5.56% 🔼) |
108/324 |
| 🔴 | Branches | 14.29% (+6.83% 🔼) |
23/161 |
| 🔴 | Functions | 27.16% (+3.7% 🔼) |
22/81 |
| 🔴 | Lines | 33.86% (+5.64% 🔼) |
108/319 |
Test suite run success
2 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from b9fe1ad
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 97.27% | 2952/3035 |
| 🟢 | Branches | 89.72% | 1685/1878 |
| 🟢 | Functions | 98.75% | 872/883 |
| 🟢 | Lines | 97.42% | 2872/2948 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / builtin-hotkey.ts |
86.67% (-3.89% 🔻) |
85.5% (-3.05% 🔻) |
87.5% (-6.25% 🔻) |
86.83% (-3.59% 🔻) |
| 🟢 | component-meta.ts | 95.89% (-1.29% 🔻) |
85.25% (-1.19% 🔻) |
96.08% (-3.92% 🔻) |
95.68% (-1.35% 🔻) |
| 🟢 | ... / node.ts |
97.89% | 89.9% | 97.56% | 98.14% |
Test suite run success
385 tests passing in 43 suites.
Report generated by 🧪jest coverage report action from b9fe1ad
liujuping
force-pushed
the
feat/notFoundCompSelect
branch
3 times, most recently
from
September 13, 2022 13:03
dab17fa to
03da7dc
Compare
liujuping
force-pushed
the
feat/notFoundCompSelect
branch
2 times, most recently
from
September 16, 2022 08:59
7f62e7d to
a5aa3bb
Compare
LeoYuan
reviewed
Sep 16, 2022
| }, | ||
| enableStrictNotFoundMode: { | ||
| type: 'boolean', | ||
| description: '当组件找不到时开启严格提示模式，不允许移动、复制，有子元素时也不渲染', |
Contributor
There was a problem hiding this comment.
这段解释不对，应该是「当开启组件未找到严格模式时，渲染模块不会默认给一个容器组件」
LeoYuan
reviewed
Sep 16, 2022
|
|
||
| /** | ||
| * @default false | ||
| * 当组件找不到时开启严格提示模式，不允许移动、复制，有子元素时也不渲染 |
liujuping
force-pushed
the
feat/notFoundCompSelect
branch
from
September 21, 2022 02:13
a5aa3bb to
5d3101e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.fixes: #974
2.新增 componentName 在 not found 视图中
