Skip to content

MsieJavaScriptEngine.ActiveScript.ActiveScriptException not wrapped #7

Description

@Daniel15

The MSIE engine catches MsieJavaScriptEngine.JsRuntimeExceptions but does not catch MsieJavaScriptEngine.ActiveScript.ActiveScriptExceptions (which can occur if there's a syntax error). These should be wrapped in an appropriate exception class. This exception type is internal so I can't even catch them to handle them nicely at the moment.

Additionally, why is the MsieJsEngine class sealed? This makes it a lot more difficult to add custom behaviour without forking the project.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions