Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ScriptedAlchemy/agent-bundle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: ScriptedAlchemy/agent-bundle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: test/remove-tree-helper
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 210 files changed
  • 1 contributor

Commits on Sep 17, 2026

  1. test(support): add removeTree, a retrying recursive delete for test t… 

    …eardown

A late writer into a tree being removed makes rm reject with ENOTEMPTY. One helper retries the transient codes so each call site does not carry its own maxRetries.
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    2bf4887 View commit details
    Browse the repository at this point in the history

  2. test: replace bare recursive rm in tests with removeTree and gate it … 

    …in lint

scripts/check-test-remove-tree.mjs fails pnpm lint on rm(..., { recursive: true }) without maxRetries under packages/*/tests. 1156 call sites across 204 files moved to removeTree.
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    a328e4e View commit details
    Browse the repository at this point in the history

  3. ci: retrigger checks after unreproducible removeTree lint failure

    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    fd6c94e View commit details
    Browse the repository at this point in the history

  4. fix(test): convert leftover recursive teardowns and catch aliased rm 

    After merging main, three install-surface teardowns still used bare
recursive rm. Convert them to removeTree, and teach the lint gate to
recognize namespace and aliased Node fs removal bindings so those forms
cannot escape the gate.
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    d62dd55 View commit details
    Browse the repository at this point in the history

  5. fix(test): make remove-tree lint syntax-aware for comments and $ aliases 

    Mask comments/strings before scanning, escape imported names literally, and
read recursive/maxRetries from real options properties so GPT P2 cases pass.
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    4a37528 View commit details
    Browse the repository at this point in the history

  6. test(support): remove the tmp dir the persistent-ENOTEMPTY test leave… 

    …s behind
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    4e3af17 View commit details
    Browse the repository at this point in the history

  7. test: declare scripts/check-test-remove-tree.mjs for the gate test's … 

    …typecheck
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    9f8184d View commit details
    Browse the repository at this point in the history

  8. fix(test): parse remove-tree lint calls with typescript-5 

    Replace comment/string masking with an AST walk so options come only
from the second argument (including quoted keys), and regex/template
edge cases no longer hide or invent recursive rm hits.
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    31151ad View commit details
    Browse the repository at this point in the history

  9. fix(test): parse Node fs removal bindings via TypeScript AST 

    Stop forging bare `rm` bindings from text regex so local identifiers and
commented-out imports cannot bypass or falsely trip the removeTree lint gate.
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    e2be2d3 View commit details
    Browse the repository at this point in the history

  10. test(remove-tree): cover AST binding regressions for GPT P2 

    Lock commented bare imports, non-fs rm imports, and aliased/namespace
maxRetries pass paths so removalBindings stays ImportDeclaration-backed.
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    3d6ba6c View commit details
    Browse the repository at this point in the history

  11. fix(test): route #824 install teardown through removeTree 

    After rebasing onto main, the Codex add-only install tests still used bare
recursive rm in finally blocks; the remove-tree lint gate correctly failed.
    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    cf340ce View commit details
    Browse the repository at this point in the history

  12. ci: retrigger checks after cancelled CI attempts on removeTree PR

    @ScriptedAlchemy
    ScriptedAlchemy committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    a8c65bf View commit details
    Browse the repository at this point in the history
Loading