Skip to content

favicon could be null, causing MCServerPing throws NullpointerException #8

Description

@RedTeaDev

Describe the bug
A clear and concise description of what the bug is.

MCServerPing throw Nullpointer

To Reproduce
Steps to reproduce the behavior:

  1. Open a minecraft server in 21w44a
  2. Join minecraft server
  3. MCServerPing.getPing("{server}", 25565);

Expected behavior
A clear and concise description of what you expected to happen.

Should not throw NullPointer

Screenshots
If applicable, add screenshots to help explain your problem.
image
image

Additional context
Add any other context about the problem here [e.g. error logs, crash logs, etc...].

java.lang.NullPointerException: Cannot invoke "com.google.gson.JsonElement.getAsString()" because the return value of "com.google.gson.JsonObject.get(String)" is null
        at dev.redcoke.mcserverping.MCServerPingResponse.serverPingFromJsonObj(MCServerPingResponse.java:38)
        at dev.redcoke.mcserverping.MCServerPing.getPing(MCServerPing.java:157)
        at dev.redcoke.mcserverping.MCServerPing.getPing(MCServerPing.java:35)
        at dev.redcoke.teapot.externalapi.java.MineCraftServerPing.getPing(MineCraftServerPing.java:10)
        at dev.redcoke.teapot.command.commands.MinecraftServer.lambda$handle$0(MinecraftServer.java:26)
        at net.dv8tion.jda.api.requests.Request.lambda$onSuccess$0(Request.java:95)
        at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1434)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:295)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1016)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1665)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1598)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)

Effected Version:

  • Since 0.1 -> 0.1.1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions