Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: OnTopicCMS/OnTopic-WebForms
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: release-4.0.0
Choose a base ref
...
head repository: OnTopicCMS/OnTopic-WebForms
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 1, 2020

  1. Fixed bug in ITypeLookupService 

    The `WebFormsTopicLookupService` had a silly bug, which effectively prevented the `ConfigurableAttributeDescriptor` from ever being registered.
    @JeremyCaney
    JeremyCaney committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    b24fa59 View commit details
    Browse the repository at this point in the history

  2. Addressed code analysis recommendations 

    These are non-functional refactorings such as implementing expression-bodied methods, or removing `this` prefixes from local property calls.
    @JeremyCaney
    JeremyCaney committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    6f1939f View commit details
    Browse the repository at this point in the history

  3. Rename Attributes to AttributeList 

    While this wasn't breaking anything currently, there was an existing property called `Attributes` on `Page` which this was effectively hiding. To mitigate that, renamed it to `AttributeList`.
    @JeremyCaney
    JeremyCaney committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    6b14d2f View commit details
    Browse the repository at this point in the history

  4. Removed references to view components 

    The template was adapted from the **OnTopic-AspNetCore** project, which exposes view components for the navigation. Those aren't supported on **Web Forms** and don't render. Therefore, they should be removed.
    @JeremyCaney
    JeremyCaney committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    658c964 View commit details
    Browse the repository at this point in the history

  5. Hotfix: Resolved issue with ITypeLookupService registration.

    @JeremyCaney
    JeremyCaney committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    b8ded5a View commit details
    Browse the repository at this point in the history
Loading