Skip to content

Commit 5b84bdd

Browse files
livecodesebastienlivecodesebastien
committed
[[ Bug 12409 ]] Fields in LC 7 fail to display binfile url imagesource
1 parent 85652eb commit 5b84bdd

3 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎docs/notes/bugfix-12409.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
# Fields in LC 7 fail to display binfile url imagesource

‎engine/src/deploy_sign.cpp‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -937,8 +937,10 @@ static bool MCDeploySignWindowsAddTimeStamp(const MCDeploySignParameters& p_para
937937
t_data . setnext(&t_url);
938938
t_url . setvalueref_argument(p_params . timestamper);
939939
extern MCExecContext *MCECptr;
940+
// SN-2014-05-09 [[ ClearResult ]]
941+
// isempty is different from isclear - 'isempty' returns false for a cleared result
940942
if (MCECptr->GetObject() -> message(MCM_post_url, &t_data, False, True) == ES_NORMAL &&
941-
MCresult -> isempty())
943+
MCresult -> isclear())
942944
{
943945
t_failed = false;
944946
break;

‎engine/src/dispatch.cpp‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1639,7 +1639,9 @@ MCObject *MCDispatch::getobjname(Chunk_term type, MCNameRef p_name)
16391639

16401640
MCAutoValueRef t_output;
16411641
MCU_geturl(*ctxt, MCNameGetString(p_name), &t_output);
1642-
if (MCresult->isempty())
1642+
// SN-2014-05-09 [[ Bug 12409 ]] Fields in LC 7 fail to display binfile url imagesource
1643+
// isempty is not what we want to use, since it returns false for a cleared result
1644+
if (MCresult->isclear())
16431645
{
16441646
MCAutoDataRef t_data;
16451647

0 commit comments

Comments
 (0)