Skip to content

Commit 3831168

Browse files
anandkaranubcanandkaranubc
committed
chore: code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 19bf4a3 commit 3831168

3 files changed

Lines changed: 15 additions & 15 deletions

File tree

‎lib/node_modules/@stdlib/math/base/special/log10f/lib/main.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ function log10f( x ) {
158158
hx = toWordf( hi ) |0; // asm type annotation
159159
hi = fromWordf( hx & HI_MASK );
160160
lo = f32( f32( f32( f - hi ) - hfsq ) + r );
161-
return f32( f32( y*LOG10_2LO ) + f32( f32( f32( lo+hi )*IVLN10LO ) + f32( f32( lo*IVLN10HI ) + f32( f32( hi*IVLN10HI ) + f32( y*LOG10_2HI ) ) ) ) ); // eslint-disable-line max-len
161+
return f32( f32( f32( f32( f32( y*LOG10_2LO ) + f32( f32( lo+hi )*IVLN10LO ) ) + f32( lo*IVLN10HI ) ) + f32( hi*IVLN10HI ) ) + f32( y*LOG10_2HI ) ); // eslint-disable-line max-len
162162
}
163163

164164

‎lib/node_modules/@stdlib/math/base/special/log10f/test/test.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ tape( 'the function evaluates the common logarithm of `x` (very large positive v
6161
for ( i = 0; i < x.length; i++ ) {
6262
y = log10f( x[ i ] );
6363
e = f32( expected[ i ] );
64-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
64+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
6565
}
6666
t.end();
6767
});
@@ -78,7 +78,7 @@ tape( 'the function evaluates the common logarithm of `x` (large positive values
7878
for ( i = 0; i < x.length; i++ ) {
7979
y = log10f( x[ i ] );
8080
e = f32( expected[ i ] );
81-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
81+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
8282
}
8383
t.end();
8484
});
@@ -95,7 +95,7 @@ tape( 'the function evaluates the common logarithm of `x` (medium positive value
9595
for ( i = 0; i < x.length; i++ ) {
9696
y = log10f( x[ i ] );
9797
e = f32( expected[ i ] );
98-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
98+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
9999
}
100100
t.end();
101101
});
@@ -112,7 +112,7 @@ tape( 'the function evaluates the common logarithm of `x` (small positive values
112112
for ( i = 0; i < x.length; i++ ) {
113113
y = log10f( x[ i ] );
114114
e = f32( expected[ i ] );
115-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
115+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
116116
}
117117
t.end();
118118
});
@@ -129,7 +129,7 @@ tape( 'the function evaluates the common logarithm of `x` (smaller positive valu
129129
for ( i = 0; i < x.length; i++ ) {
130130
y = log10f( x[ i ] );
131131
e = f32( expected[ i ] );
132-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
132+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
133133
}
134134
t.end();
135135
});
@@ -146,7 +146,7 @@ tape( 'the function evaluates the common logarithm of `x` (tiny positive values)
146146
for ( i = 0; i < x.length; i++ ) {
147147
y = log10f( x[ i ] );
148148
e = f32( expected[ i ] );
149-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
149+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
150150
}
151151
t.end();
152152
});
@@ -163,7 +163,7 @@ tape( 'the function evaluates the common logarithm of `x` (subnormal values)', f
163163
for ( i = 0; i < x.length; i++ ) {
164164
y = log10f( x[ i ] );
165165
e = f32( expected[ i ] );
166-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
166+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
167167
}
168168
t.end();
169169
});

‎lib/node_modules/@stdlib/math/base/special/log10f/test/test.native.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ tape( 'the function evaluates the common logarithm of `x` (very large positive v
7070
for ( i = 0; i < x.length; i++ ) {
7171
y = log10f( x[ i ] );
7272
e = f32( expected[ i ] );
73-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
73+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
7474
}
7575
t.end();
7676
});
@@ -87,7 +87,7 @@ tape( 'the function evaluates the common logarithm of `x` (large positive values
8787
for ( i = 0; i < x.length; i++ ) {
8888
y = log10f( x[ i ] );
8989
e = f32( expected[ i ] );
90-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
90+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
9191
}
9292
t.end();
9393
});
@@ -104,7 +104,7 @@ tape( 'the function evaluates the common logarithm of `x` (medium positive value
104104
for ( i = 0; i < x.length; i++ ) {
105105
y = log10f( x[ i ] );
106106
e = f32( expected[ i ] );
107-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
107+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
108108
}
109109
t.end();
110110
});
@@ -121,7 +121,7 @@ tape( 'the function evaluates the common logarithm of `x` (small positive values
121121
for ( i = 0; i < x.length; i++ ) {
122122
y = log10f( x[ i ] );
123123
e = f32( expected[ i ] );
124-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
124+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
125125
}
126126
t.end();
127127
});
@@ -138,7 +138,7 @@ tape( 'the function evaluates the common logarithm of `x` (smaller positive valu
138138
for ( i = 0; i < x.length; i++ ) {
139139
y = log10f( x[ i ] );
140140
e = f32( expected[ i ] );
141-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
141+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
142142
}
143143
t.end();
144144
});
@@ -155,7 +155,7 @@ tape( 'the function evaluates the common logarithm of `x` (tiny positive values)
155155
for ( i = 0; i < x.length; i++ ) {
156156
y = log10f( x[ i ] );
157157
e = f32( expected[ i ] );
158-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
158+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
159159
}
160160
t.end();
161161
});
@@ -172,7 +172,7 @@ tape( 'the function evaluates the common logarithm of `x` (subnormal values)', o
172172
for ( i = 0; i < x.length; i++ ) {
173173
y = log10f( x[ i ] );
174174
e = f32( expected[ i ] );
175-
t.strictEqual( isAlmostSameValuef( y, e, 2 ), true, 'returns expected value' );
175+
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
176176
}
177177
t.end();
178178
});

0 commit comments

Comments
 (0)