Skip to content

Commit 5efc85b

Browse files
iclantoniclanton
committed
Update instances of "NodeJS" to "Node.js"
1 parent 28502f7 commit 5efc85b

9 files changed

Lines changed: 20 additions & 20 deletions

File tree

‎apps/rush-lib/assets/rush-init/rush.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,11 @@
6262
},
6363

6464
/**
65-
* Older releases of the NodeJS engine may be missing features required by your system.
65+
* Older releases of the Node.js engine may be missing features required by your system.
6666
* Other releases may have bugs. In particular, the "latest" version will not be a
6767
* Long Term Support (LTS) version and is likely to have regressions.
6868
*
69-
* Specify a SemVer range to ensure developers use a NodeJS version that is appropriate
69+
* Specify a SemVer range to ensure developers use a Node.js version that is appropriate
7070
* for your repo.
7171
*/
7272
"nodeSupportedVersionRange": ">=10.13.0 <11.0.0",
@@ -113,7 +113,7 @@
113113
* occasionally, but if that's painful, it's a warning sign that your development style may
114114
* discourage refactoring. Reorganizing the categories should be an enlightening discussion
115115
* that brings people together, and maybe also identifies poor coding practices (e.g. file
116-
* references that reach into other project's folders without using NodeJS module resolution).
116+
* references that reach into other project's folders without using Node.js module resolution).
117117
*
118118
* The defaults are projectFolderMinDepth=1 and projectFolderMaxDepth=2.
119119
*

‎apps/rush-lib/src/api/Rush.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export interface ILaunchOptions {
2424
isManaged: boolean;
2525

2626
/**
27-
* If true, the wrapper process already printed a warning that the version of NodeJS hasn't been tested
27+
* If true, the wrapper process already printed a warning that the version of Node.js hasn't been tested
2828
* with this version of Rush, so we shouldn't print a similar error.
2929
*/
3030
alreadyReportedNodeTooNewError?: boolean;
@@ -39,7 +39,7 @@ export class Rush {
3939
/**
4040
* This API is used by the `@microsoft/rush` front end to launch the "rush" command-line.
4141
* Third-party tools should not use this API. Instead, they should execute the "rush" binary
42-
* and start a new NodeJS process.
42+
* and start a new Node.js process.
4343
*
4444
* @param launcherVersion - The version of the `@microsoft/rush` wrapper used to call invoke the CLI.
4545
*/
@@ -66,7 +66,7 @@ export class Rush {
6666
/**
6767
* This API is used by the `@microsoft/rush` front end to launch the "rushx" command-line.
6868
* Third-party tools should not use this API. Instead, they should execute the "rushx" binary
69-
* and start a new NodeJS process.
69+
* and start a new Node.js process.
7070
*
7171
* @param launcherVersion - The version of the `@microsoft/rush` wrapper used to call invoke the CLI.
7272
*/
@@ -119,7 +119,7 @@ export class Rush {
119119
}
120120

121121
private static _printStartupBanner(isManaged: boolean): void {
122-
interface IExtendedNodeProcess extends NodeJS.Process {
122+
interface IExtendedNodeProcess extends Node.js.Process {
123123
release: {
124124
lts?: string;
125125
};
@@ -136,15 +136,15 @@ export class Rush {
136136
colors.bold(`Rush Multi-Project Build Tool ${Rush.version}` + colors.yellow(isManaged ? '' : ' (unmanaged)')) +
137137
colors.cyan(` - ${RushConstants.rushWebSiteUrl}`) +
138138
EOL +
139-
`NodeJS version is ${nodeVersion} (${nodeReleaseLabel})` +
139+
`Node.js version is ${nodeVersion} (${nodeReleaseLabel})` +
140140
EOL
141141
);
142142
}
143143

144144
private static _warnAboutNodeVersion(rushConfiguration: RushConfiguration | undefined): void {
145145
const nodeVersion: string = process.versions.node;
146146

147-
interface IExtendedNodeProcess extends NodeJS.Process {
147+
interface IExtendedNodeProcess extends Node.js.Process {
148148
release: {
149149
lts?: string;
150150
};

‎apps/rush-lib/src/cli/RushCommandLineParser.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ export class RushCommandLineParser extends CommandLineParser {
9292

9393
protected onExecute(): Promise<void> {
9494
// Defensively set the exit code to 1 so if Rush crashes for whatever reason, we'll have a nonzero exit code.
95-
// For example, NodeJS currently has the inexcusable design of terminating with zero exit code when
96-
// there is an uncaught promise exception. This will supposedly be fixed in NodeJS 9.
95+
// For example, Node.js currently has the inexcusable design of terminating with zero exit code when
96+
// there is an uncaught promise exception. This will supposedly be fixed in Node.js 9.
9797
// Ideally we should do this for all the Rush actions, but "rush build" is the most critical one
9898
// -- if it falsely appears to succeed, we could merge bad PRs, publish empty packages, etc.
9999
process.exitCode = 1;
@@ -334,7 +334,7 @@ export class RushCommandLineParser extends CommandLineParser {
334334
}
335335

336336
if (this._debugParameter.value) {
337-
// If catchSyncErrors() called this, then show a call stack similar to what NodeJS
337+
// If catchSyncErrors() called this, then show a call stack similar to what Node.js
338338
// would show for an uncaught error
339339
console.error(os.EOL + error.stack);
340340
}

‎apps/rush-lib/src/cli/RushXCommandLine.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class RushXCommandLine {
4040
* @internal
4141
*/
4242
public static _launchRushXInternal(launcherVersion: string, options: ILaunchRushXInternalOptions): void {
43-
// NodeJS can sometimes accidentally terminate with a zero exit code (e.g. for an uncaught
43+
// Node.js can sometimes accidentally terminate with a zero exit code (e.g. for an uncaught
4444
// promise exception), so we start with the assumption that the exit code is 1
4545
// and set it to 0 only on success.
4646
process.exitCode = 1;

‎apps/rush-lib/src/logic/InstallManager.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -991,7 +991,7 @@ export class InstallManager {
991991
if (FileSystem.exists(lastCheckFile)) {
992992
let cachedResult: boolean | 'error' | undefined = undefined;
993993
try {
994-
// NOTE: mtimeMs is not supported yet in NodeJS 6.x
994+
// NOTE: mtimeMs is not supported yet in Node.js 6.x
995995
const nowMs: number = new Date().getTime();
996996
const ageMs: number = nowMs - FileSystem.getStatistics(lastCheckFile).mtime.getTime();
997997
const HOUR: number = 60 * 60 * 1000;

‎apps/rush-lib/src/utilities/AsyncRecycler.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export class AsyncRecycler {
114114

115115
/**
116116
* Starts an asynchronous process to delete the recycler folder. Deleting will continue
117-
* even if the current NodeJS process is killed.
117+
* even if the current Node.js process is killed.
118118
*
119119
* NOTE: To avoid spawning multiple instances of the same command, moveFolder()
120120
* MUST NOT be called again after deleteAll() has started.

‎apps/rush-lib/src/utilities/Utilities.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export class Utilities {
121121
}
122122

123123
/**
124-
* NodeJS equivalent of performance.now().
124+
* Node.js equivalent of performance.now().
125125
*/
126126
public static getTimeInMs(): number {
127127
let seconds: number;
@@ -722,7 +722,7 @@ export class Utilities {
722722

723723
if (result.error && (result.error as any).errno === 'ENOENT') { // tslint:disable-line:no-any
724724
// This is a workaround for GitHub issue #25330
725-
// https://github.com/nodejs/node-v0.x-archive/issues/25330
725+
// https://github.com/Node.js/node-v0.x-archive/issues/25330
726726
result = child_process.spawnSync(command + '.cmd', args, options);
727727
}
728728

‎apps/rush/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
- **Automatic local linking:** Inside a Rush repo, all your projects are automatically symlinked to each other. When you make a change, you can see the downstream effects without publishing anything, and without any `npm link` headaches. If you don't want certain projects to get linked, that's supported, too.
1919

20-
- **Fast builds:** Rush detects your dependency graph and builds your projects in the right order. If two packages don't directly depend on each other, Rush parallelizes their build as separate NodeJS processes (and shows live console output in a [readable order](https://www.npmjs.com/package/@microsoft/stream-collator)). In practice this multi-process approach can yield more significant speedups than all those async functions in your single-threaded Gulpfile.
20+
- **Fast builds:** Rush detects your dependency graph and builds your projects in the right order. If two packages don't directly depend on each other, Rush parallelizes their build as separate Node.js processes (and shows live console output in a [readable order](https://www.npmjs.com/package/@microsoft/stream-collator)). In practice this multi-process approach can yield more significant speedups than all those async functions in your single-threaded Gulpfile.
2121

2222
- **Subset and incremental builds:** If you only plan to work with a few projects from your repo, `rush rebuild --to <project>` does a clean build of just your upstream dependencies. After you make changes, `rush rebuild --from <project>` does a clean build of only the affected downstream projects. And if your toolchain is [package-deps-hash](https://www.npmjs.com/package/@microsoft/package-deps-hash) enabled, `rush build` delivers a powerful cross-project incremental build (that also supports subset builds).
2323

‎apps/rush/src/start.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
22
// See LICENSE in the project root for license information.
33

4-
// The minimal set of imports that are safe even for ancient NodeJS versions:
4+
// The minimal set of imports that are safe even for ancient Node.js versions:
55
import * as colors from 'colors';
66
import * as os from 'os';
77
import * as semver from 'semver';
88

99
const nodeVersion: string = process.versions.node;
1010
let alreadyReportedNodeTooNewError: boolean = false;
1111

12-
// We are on an ancient version of NodeJS that is known not to work with Rush
12+
// We are on an ancient version of Node.js that is known not to work with Rush
1313
if (semver.satisfies(nodeVersion, '< 8.9.0')) {
1414
console.error(colors.red(
1515
`Your version of Node.js (${nodeVersion}) is very old and incompatible with Rush. ` +

0 commit comments

Comments
 (0)