Skip to content

Commit f35c794

Browse files
jevanccjevancc
committed
update sideEffects test
1 parent c334d08 commit f35c794

5 files changed

Lines changed: 15 additions & 9 deletions

File tree

‎test/SideEffectsFlagPlugin.unittest.js‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,19 @@ describe("SideEffectsFlagPlugin", () => {
1515
it("should understand a glob", () => {
1616
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "./src/**/*.js").should.eql(true);
1717
SideEffectsFlagPlugin.moduleHasSideEffects("./x.js", "./src/**/*.js").should.eql(false);
18+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "./**/src/x/y/z.js").should.eql(true);
1819
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "**.js").should.eql(true);
19-
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "./src**").should.eql(true);
2020
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "./src/**/z.js").should.eql(true);
21-
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "**/x/**/z.js").should.eql(true);
21+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "./**/x/**/z.js").should.eql(true);
22+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "./**/src/**").should.eql(true);
23+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "./**/src/*").should.eql(false);
24+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "*.js").should.eql(true);
25+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "x/**/z.js").should.eql(false);
26+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "src/**/z.js").should.eql(true);
27+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "src/**/{x,y,z}.js").should.eql(true);
28+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "src/**/[x-z].js").should.eql(true);
29+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "src/**/[[:lower:]].js").should.eql(true);
30+
SideEffectsFlagPlugin.moduleHasSideEffects("./src/x/y/z.js", "!**/*.js").should.eql(false);
2231
});
2332

2433
it("should understand arrays", () => {

‎test/configCases/side-effects/side-effects-override/webpack.config.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@ const path = require("path");
22
module.exports = {
33
mode: "production",
44
module: {
5-
rules: [
6-
7-
{
5+
rules: [{
86
test: path.resolve(__dirname, "node_modules/pmodule"),
97
sideEffects: true
108
},

‎test/configCases/side-effects/side-effects-values/node_modules/boolean-value-module/package.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/configCases/side-effects/side-effects-values/node_modules/glob-value-module/package.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/configCases/side-effects/side-effects-values/webpack.config.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
module.exports = {
22
mode: "production",
33
module: {
4-
rules: [
5-
]
4+
rules: []
65
}
76
};

0 commit comments

Comments
 (0)