Skip to content

Commit 83f772a

Browse files
author
ruszki
committed
Remove footer from source maps and eval
1 parent c963e3d commit 83f772a

7 files changed

Lines changed: 11 additions & 34 deletions

File tree

‎lib/EvalDevToolModuleTemplatePlugin.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,7 @@ class EvalDevToolModuleTemplatePlugin {
2424
moduleFilenameTemplate: this.moduleFilenameTemplate,
2525
namespace: this.namespace
2626
}, moduleTemplate.runtimeTemplate.requestShortener);
27-
const footer = ["\n",
28-
ModuleFilenameHelpers.createFooter(module, moduleTemplate.runtimeTemplate.requestShortener),
29-
this.sourceUrlComment.replace(/\[url\]/g, encodeURI(str).replace(/%2F/g, "/").replace(/%20/g, "_").replace(/%5E/g, "^").replace(/%5C/g, "\\").replace(/^\//, ""))
30-
].join("\n");
27+
const footer = this.sourceUrlComment.replace(/\[url\]/g, encodeURI(str).replace(/%2F/g, "/").replace(/%20/g, "_").replace(/%5E/g, "^").replace(/%5C/g, "\\").replace(/^\//, ""));
3128
const result = new RawSource(`eval(${JSON.stringify(content + footer)});`);
3229
cache.set(source, result);
3330
return result;

‎lib/EvalSourceMapDevToolModuleTemplatePlugin.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,7 @@ class EvalSourceMapDevToolModuleTemplatePlugin {
5858
});
5959
sourceMap.sources = moduleFilenames;
6060
if(sourceMap.sourcesContent) {
61-
sourceMap.sourcesContent = sourceMap.sourcesContent.map((content, i) => {
62-
return typeof content === "string" ? `${content}\n\n\n${ModuleFilenameHelpers.createFooter(modules[i], moduleTemplate.runtimeTemplate.requestShortener)}` : null;
63-
});
61+
sourceMap.sourcesContent = sourceMap.sourcesContent.map(content => typeof content === "string" ? content : null);
6462
}
6563
sourceMap.sourceRoot = options.sourceRoot || "";
6664
sourceMap.file = `${module.id}.js`;

‎lib/ModuleFilenameHelpers.js‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -112,24 +112,6 @@ ModuleFilenameHelpers.createFilename = (module, options, requestShortener) => {
112112
.replace(ModuleFilenameHelpers.REGEXP_NAMESPACE, opts.namespace);
113113
};
114114

115-
ModuleFilenameHelpers.createFooter = (module, requestShortener) => {
116-
if(!module) module = "";
117-
if(typeof module === "string") {
118-
return [
119-
"// WEBPACK FOOTER //",
120-
`// ${requestShortener.shorten(module)}`
121-
].join("\n");
122-
} else {
123-
return [
124-
"//////////////////",
125-
"// WEBPACK FOOTER",
126-
`// ${module.readableIdentifier(requestShortener)}`,
127-
`// module id = ${module.id}`,
128-
`// module chunks = ${Array.from(module.chunksIterable, c => c.id).join(" ")}`
129-
].join("\n");
130-
}
131-
};
132-
133115
ModuleFilenameHelpers.replaceDuplicates = (array, fn, comparator) => {
134116
const countMap = Object.create(null);
135117
const posMap = Object.create(null);

‎lib/SourceMapDevToolPlugin.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ class SourceMapDevToolPlugin {
185185
const moduleFilenames = modules.map(m => moduleToSourceNameMapping.get(m));
186186
sourceMap.sources = moduleFilenames;
187187
if(sourceMap.sourcesContent && !options.noSources) {
188-
sourceMap.sourcesContent = sourceMap.sourcesContent.map((content, i) => typeof content === "string" ? `${content}\n\n\n${ModuleFilenameHelpers.createFooter(modules[i], requestShortener)}` : null);
188+
sourceMap.sourcesContent = sourceMap.sourcesContent.map((content) => typeof content === "string" ? content : null);
189189
} else {
190190
sourceMap.sourcesContent = undefined;
191191
}

‎test/statsCases/chunks-development/expected.txt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
Hash: 5ce1f032cffdff8368b5
22
Time: Xms
33
Asset Size Chunks Chunk Names
4-
0.bundle.js 530 bytes 0 [emitted]
5-
1.bundle.js 394 bytes 1 [emitted]
6-
2.bundle.js 782 bytes 2 [emitted]
7-
bundle.js 7.58 KiB main [emitted] main
4+
0.bundle.js 431 bytes 0 [emitted]
5+
1.bundle.js 295 bytes 1 [emitted]
6+
2.bundle.js 584 bytes 2 [emitted]
7+
bundle.js 7.38 KiB main [emitted] main
88
Entrypoint main = bundle.js
99
chunk {main} bundle.js (main) 73 bytes >{0}< >{1}< [entry] [rendered]
1010
> ./index main

‎test/statsCases/preset-normal-performance-ensure-filter-sourcemaps/expected.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ Time: <CLR=BOLD>X</CLR>ms
44
<CLR=32,BOLD>1.js</CLR> 319 bytes <CLR=BOLD>1</CLR> <CLR=32,BOLD>[emitted]</CLR>
55
<CLR=33,BOLD>main.js</CLR> <CLR=33,BOLD>300 KiB</CLR> <CLR=BOLD>2</CLR> <CLR=32,BOLD>[emitted]</CLR> <CLR=33,BOLD>[big]</CLR> main
66
<CLR=32,BOLD>3.js</CLR> 257 bytes <CLR=BOLD>3</CLR> <CLR=32,BOLD>[emitted]</CLR>
7-
<CLR=32,BOLD>0.js.map</CLR> 250 bytes <CLR=BOLD>0</CLR> <CLR=32,BOLD>[emitted]</CLR>
8-
<CLR=32,BOLD>1.js.map</CLR> 291 bytes <CLR=BOLD>1</CLR> <CLR=32,BOLD>[emitted]</CLR>
7+
<CLR=32,BOLD>0.js.map</CLR> 156 bytes <CLR=BOLD>0</CLR> <CLR=32,BOLD>[emitted]</CLR>
8+
<CLR=32,BOLD>1.js.map</CLR> 197 bytes <CLR=BOLD>1</CLR> <CLR=32,BOLD>[emitted]</CLR>
99
<CLR=32,BOLD>main.js.map</CLR> 1.72 MiB <CLR=BOLD>2</CLR> <CLR=32,BOLD>[emitted]</CLR> main
10-
<CLR=32,BOLD>3.js.map</CLR> 402 bytes <CLR=BOLD>3</CLR> <CLR=32,BOLD>[emitted]</CLR>
10+
<CLR=32,BOLD>3.js.map</CLR> 214 bytes <CLR=BOLD>3</CLR> <CLR=32,BOLD>[emitted]</CLR>
1111
Entrypoint <CLR=BOLD>main</CLR> <CLR=33,BOLD>[big]</CLR> = <CLR=32,BOLD>main.js</CLR> <CLR=32,BOLD>main.js.map</CLR>
1212
[0] <CLR=BOLD>./d.js</CLR> 22 bytes {<CLR=33,BOLD>3</CLR>}<CLR=32,BOLD> [built]</CLR>
1313
[1] <CLR=BOLD>./e.js</CLR> 22 bytes {<CLR=33,BOLD>3</CLR>}<CLR=32,BOLD> [built]</CLR>

‎test/statsCases/simple/expected.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Hash: f0bbd0723c33cf044c2f
22
Time: Xms
33
Asset Size Chunks Chunk Names
4-
bundle.js 2.89 KiB main [emitted] main
4+
bundle.js 2.78 KiB main [emitted] main
55
Entrypoint main = bundle.js
66
[./index.js] 0 bytes {main} [built]

0 commit comments

Comments
 (0)