Skip to content

Commit 82eec17

Browse files
committed
convert more usages of BasicEvaluatedExpression with ParserHelpers
1 parent 965b726 commit 82eec17

3 files changed

Lines changed: 5 additions & 19 deletions

File tree

lib/ConstPlugin.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@
33
Author Tobias Koppers @sokra
44
*/
55
"use strict";
6-
76
const ConstDependency = require("./dependencies/ConstDependency");
8-
const BasicEvaluatedExpression = require("./BasicEvaluatedExpression");
97
const NullFactory = require("./NullFactory");
8+
const ParserHelpers = require("./ParserHelpers");
109

1110
const getQuery = (request) => {
1211
const i = request.indexOf("?");
@@ -46,10 +45,7 @@ class ConstPlugin {
4645
});
4746
parser.plugin("evaluate Identifier __resourceQuery", function(expr) {
4847
if(!this.state.module) return;
49-
const res = new BasicEvaluatedExpression();
50-
res.setString(getQuery(this.state.module.resource));
51-
res.setRange(expr.range);
52-
return res;
48+
return ParserHelpers.evaluateToString(getQuery(this.state.module.resource))(expr);
5349
});
5450
parser.plugin("expression __resourceQuery", function() {
5551
if(!this.state.module) return;

lib/HotModuleReplacementPlugin.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55
"use strict";
66
var Template = require("./Template");
7-
var BasicEvaluatedExpression = require("./BasicEvaluatedExpression");
87
var ModuleHotAcceptDependency = require("./dependencies/ModuleHotAcceptDependency");
98
var ModuleHotDeclineDependency = require("./dependencies/ModuleHotDeclineDependency");
109
var RawSource = require("webpack-sources").RawSource;
@@ -200,9 +199,7 @@ HotModuleReplacementPlugin.prototype.apply = function(compiler) {
200199
parser.plugin("expression __webpack_hash__", ParserHelpers.toConstantDependency("__webpack_require__.h()"));
201200
parser.plugin("evaluate typeof __webpack_hash__", ParserHelpers.evaluateToString("string"));
202201
parser.plugin("evaluate Identifier module.hot", function(expr) {
203-
return new BasicEvaluatedExpression()
204-
.setBoolean(!!this.state.compilation.hotUpdateChunkTemplate)
205-
.setRange(expr.range);
202+
return ParserHelpers.evaluateToBoolean(!!this.state.compilation.hotUpdateChunkTemplate)(expr);
206203
});
207204
parser.plugin("call module.hot.accept", function(expr) {
208205
if(!this.state.compilation.hotUpdateChunkTemplate) return false;

lib/NodeStuffPlugin.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
var path = require("path");
66
var ParserHelpers = require("./ParserHelpers");
77
var ConstDependency = require("./dependencies/ConstDependency");
8-
var BasicEvaluatedExpression = require("./BasicEvaluatedExpression");
98

109
var NullFactory = require("./NullFactory");
1110

@@ -51,12 +50,9 @@ NodeStuffPlugin.prototype.apply = function(compiler) {
5150
}
5251
parser.plugin("evaluate Identifier __filename", function(expr) {
5352
if(!this.state.module) return;
54-
var res = new BasicEvaluatedExpression();
5553
var resource = this.state.module.resource;
5654
var i = resource.indexOf("?");
57-
res.setString(i < 0 ? resource : resource.substr(0, i));
58-
res.setRange(expr.range);
59-
return res;
55+
return ParserHelpers.evaluateToString(i < 0 ? resource : resource.substr(0, i))(expr);
6056
});
6157
if(localOptions.__dirname === "mock") {
6258
setConstant("__dirname", "/");
@@ -67,10 +63,7 @@ NodeStuffPlugin.prototype.apply = function(compiler) {
6763
}
6864
parser.plugin("evaluate Identifier __dirname", function(expr) {
6965
if(!this.state.module) return;
70-
var res = new BasicEvaluatedExpression();
71-
res.setString(this.state.module.context);
72-
res.setRange(expr.range);
73-
return res;
66+
return ParserHelpers.evaluateToString(this.state.module.context)(expr);
7467
});
7568
parser.plugin("expression require.main", ParserHelpers.toConstantDependency("__webpack_require__.c[__webpack_require__.s]"));
7669
parser.plugin(

0 commit comments

Comments
 (0)