Skip to content

Commit 51ccbd4

Browse files
committed
make use of block scoping of let/const in RequireResolveDependencyParserPlugin ImportParserPlugin
1 parent 728566d commit 51ccbd4

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

lib/dependencies/ImportParserPlugin.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,13 @@ class ImportParserPlugin {
1818
parser.plugin(["call System.import", "import-call"], (expr) => {
1919
if(expr.arguments.length !== 1)
2020
throw new Error("Incorrect number of arguments provided to 'import(module: string) -> Promise'.");
21-
let dep;
2221
const param = parser.evaluateExpression(expr.arguments[0]);
2322
if(param.isString()) {
2423
const depBlock = new ImportDependenciesBlock(param.string, expr.range, parser.state.module, expr.loc);
2524
parser.state.current.addBlock(depBlock);
2625
return true;
2726
} else {
28-
dep = ContextDependencyHelpers.create(ImportContextDependency, expr.range, param, expr, options);
27+
const dep = ContextDependencyHelpers.create(ImportContextDependency, expr.range, param, expr, options);
2928
if(!dep) return;
3029
dep.loc = expr.loc;
3130
dep.optional = !!parser.scope.inTry;

lib/dependencies/RequireResolveDependencyParserPlugin.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,14 @@ class RequireResolveDependencyParserPlugin {
2525
parser.plugin("call require.resolve(Weak)", (expr, weak) => {
2626
if(expr.arguments.length !== 1) return;
2727
const param = parser.evaluateExpression(expr.arguments[0]);
28-
let dep;
2928
if(param.isConditional()) {
3029
param.options.forEach((option) => {
3130
const result = parser.applyPluginsBailResult("call require.resolve(Weak):item", expr, option, weak);
3231
if(result === undefined) {
3332
parser.applyPluginsBailResult("call require.resolve(Weak):context", expr, option, weak);
3433
}
3534
});
36-
dep = new RequireResolveHeaderDependency(expr.callee.range);
35+
const dep = new RequireResolveHeaderDependency(expr.callee.range);
3736
dep.loc = expr.loc;
3837
parser.state.current.addDependency(dep);
3938
return true;
@@ -42,7 +41,7 @@ class RequireResolveDependencyParserPlugin {
4241
if(result === undefined) {
4342
parser.applyPluginsBailResult("call require.resolve(Weak):context", expr, param, weak);
4443
}
45-
dep = new RequireResolveHeaderDependency(expr.callee.range);
44+
const dep = new RequireResolveHeaderDependency(expr.callee.range);
4645
dep.loc = expr.loc;
4746
parser.state.current.addDependency(dep);
4847
return true;

0 commit comments

Comments
 (0)