Skip to content

Commit 4ae95a6

Browse files
author
Mohsen Azimi
committed
Add HideStackError class for errors that have hideStack = true
1 parent 0e404b8 commit 4ae95a6

4 files changed

Lines changed: 18 additions & 9 deletions

File tree

‎lib/HiddenStackError.js‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
/*
2+
MIT License http://www.opensource.org/licenses/mit-license.php
3+
*/
4+
"use strict";
5+
6+
module.exports = class HiddenStackError extends Error {
7+
constructor(...args) {
8+
super(...args);
9+
this.hideStack = true;
10+
}
11+
};

‎lib/dependencies/HarmonyExportImportedSpecifierDependency.js‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"use strict";
66
const HarmonyImportDependency = require("./HarmonyImportDependency");
77
const Template = require("../Template");
8+
const HiddenStackError = require("../HiddenStackError");
89

910
class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
1011
constructor(
@@ -340,10 +341,9 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
340341
const exportName = this.id
341342
? `the named export '${this.id}'`
342343
: "the namespace object";
343-
const err = new Error(
344+
const err = new HiddenStackError(
344345
`Can't reexport ${exportName} from non EcmaScript module (only default export is available)`
345346
);
346-
err.hideStack = true;
347347
return [err];
348348
}
349349
return;
@@ -364,8 +364,7 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency {
364364
const errorMessage = `"export '${
365365
this.id
366366
}'${idIsNotNameMessage} was not found in '${this.userRequest}'`;
367-
const err = new Error(errorMessage);
368-
err.hideStack = true;
367+
const err = new HiddenStackError(errorMessage);
369368
return [err];
370369
}
371370

‎lib/dependencies/HarmonyImportSpecifierDependency.js‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55
"use strict";
66
const HarmonyImportDependency = require("./HarmonyImportDependency");
7+
const HiddenStackError = require("../HiddenStackError");
78

89
class HarmonyImportSpecifierDependency extends HarmonyImportDependency {
910
constructor(
@@ -76,10 +77,9 @@ class HarmonyImportSpecifierDependency extends HarmonyImportDependency {
7677
const exportName = this.id
7778
? `the named export '${this.id}'`
7879
: "the namespace object";
79-
const err = new Error(
80+
const err = new HiddenStackError(
8081
`Can't import ${exportName} from non EcmaScript module (only default export is available)`
8182
);
82-
err.hideStack = true;
8383
return [err];
8484
}
8585
return;
@@ -100,8 +100,7 @@ class HarmonyImportSpecifierDependency extends HarmonyImportDependency {
100100
const errorMessage = `"export '${
101101
this.id
102102
}'${idIsNotNameMessage} was not found in '${this.userRequest}'`;
103-
const err = new Error(errorMessage);
104-
err.hideStack = true;
103+
const err = new HiddenStackError(errorMessage);
105104
return [err];
106105
}
107106

‎test/cases/compile/error-hide-stack/loader.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ module.exports = function() {
33
err.stack = "Stack";
44
err.hideStack = true;
55
throw err;
6-
};
6+
};

0 commit comments

Comments
 (0)