Skip to content

Commit 308ddf2

Browse files
committed
fixed missing convertions in examples
1 parent 5b0cb05 commit 308ddf2

6 files changed

Lines changed: 16 additions & 13 deletions

File tree

examples/buildAll.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var path = require("path");
33
var fs = require("fs");
44

55
var cmds = fs.readdirSync(__dirname).filter(function(dirname) {
6-
return fs.statSync(path.join(__dirname, dirname)).isDirectory();
6+
return fs.statSync(path.join(__dirname, dirname)).isDirectory() && dirname !== "node_modules";
77
}).sort().map(function(dirname) {
88
return "cd " + dirname + " && node build.js";
99
});

examples/multiple-commons-chunks/webpack.config.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ module.exports = {
1515
},
1616
plugins: [
1717
new CommonsChunkPlugin({
18-
name: "admin-commons.js",
18+
name: "admin-commons",
1919
chunks: ["adminPageA", "adminPageB"]
2020
}),
2121
new CommonsChunkPlugin({
22-
name: "commons.js",
22+
name: "commons",
2323
chunks: ["pageA", "pageB", "admin-commons.js"],
2424
minChunks: 2
2525
}),
2626
new CommonsChunkPlugin({
27-
name: "c-commons.js",
27+
name: "c-commons",
2828
chunks: ["pageC", "adminPageC"]
2929
}),
3030
]

examples/multiple-entry-points/template.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,10 @@ You can also see the info that is printed to console. It shows among others:
6868
{{js/pageB.bundle.js}}
6969
```
7070

71-
# js/1.chunk.js
71+
# js/0.chunk.js
7272

7373
``` javascript
74-
{{js/1.chunk.js}}
74+
{{js/0.chunk.js}}
7575
```
7676

7777
# Info

examples/multiple-entry-points/webpack.config.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ module.exports = {
1111
chunkFilename: "[id].chunk.js"
1212
},
1313
plugins: [
14-
new CommonsChunkPlugin("commons.js")
14+
new CommonsChunkPlugin({
15+
filename: "commons.js",
16+
name: "commons"
17+
})
1518
]
1619
}

examples/named-chunks/template.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@
1111
{{js/output.js}}
1212
```
1313

14-
# js/1.js
14+
# js/0.js
1515

1616
``` javascript
17-
{{js/1.js}}
17+
{{js/0.js}}
1818
```
1919

20-
# js/2.js
20+
# js/1.js
2121

2222
``` javascript
23-
{{js/2.js}}
23+
{{js/1.js}}
2424
```
2525

2626
# Info

examples/web-worker/template.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323
{{js/hash.worker.js}}
2424
```
2525

26-
# js/1.[hash].worker.hs
26+
# js/0.[hash].worker.hs
2727

2828
``` javascript
29-
{{js/1.hash.worker.js}}
29+
{{js/0.hash.worker.js}}
3030
```
3131

3232
# Info

0 commit comments

Comments
 (0)