Skip to content

Commit 139d5ab

Browse files
jharris4jharris4
committed
Update error callback named chunk tests to have unique/distinct query params and chunk names from other tests to ensure there is no contamination of other tests
1 parent 5418e50 commit 139d5ab

1 file changed

Lines changed: 30 additions & 30 deletions

File tree

‎test/cases/chunks/named-chunks/index.js‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -35,37 +35,37 @@ it("should handle empty named chunks", function(done) {
3535
});
3636

3737
it("should handle named chunks when there is an error callback", function(done) {
38-
var sync = false;
39-
require.ensure([], function(require) {
40-
require("./empty?a");
41-
require("./empty?b");
42-
testLoad();
43-
sync = true;
44-
process.nextTick(function() {
45-
sync = false;
46-
});
47-
}, function(error) {}, "named-chunk");
48-
function testLoad() {
49-
require.ensure([], function(require) {
50-
require("./empty?c");
51-
require("./empty?d");
52-
sync.should.be.ok();
53-
done();
54-
}, function(error) {}, "named-chunk");
55-
}
38+
var sync = false;
39+
require.ensure([], function(require) {
40+
require("./empty?e");
41+
require("./empty?f");
42+
testLoad();
43+
sync = true;
44+
process.nextTick(function() {
45+
sync = false;
46+
});
47+
}, function(error) {}, "named-chunk-for-error-callback");
48+
function testLoad() {
49+
require.ensure([], function(require) {
50+
require("./empty?g");
51+
require("./empty?h");
52+
sync.should.be.ok();
53+
done();
54+
}, function(error) {}, "named-chunk-for-error-callback");
55+
}
5656
});
5757

5858
it("should handle empty named chunks when there is an error callback", function(done) {
59-
var sync = false;
60-
require.ensure([], function(require) {
61-
sync.should.be.ok();
62-
}, function(error) {}, "empty-named-chunk");
63-
require.ensure([], function(require) {
64-
sync.should.be.ok();
65-
done();
66-
}, function(error) {}, "empty-named-chunk");
67-
sync = true;
68-
setImmediate(function() {
69-
sync = false;
70-
});
59+
var sync = false;
60+
require.ensure([], function(require) {
61+
sync.should.be.ok();
62+
}, function(error) {}, "empty-named-chunk-for-error-callback");
63+
require.ensure([], function(require) {
64+
sync.should.be.ok();
65+
done();
66+
}, function(error) {}, "empty-named-chunk-for-error-callback");
67+
sync = true;
68+
setImmediate(function() {
69+
sync = false;
70+
});
7171
});

0 commit comments

Comments
 (0)