Skip to content

Commit 07f6281

Browse files
e-cloude-cloud
committed
fix: typos and variables/function misuse
1 parent 52055ba commit 07f6281

5 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎lib/ChunkTemplate.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ module.exports = class ChunkTemplate extends Template {
1313
}
1414

1515
render(chunk, moduleTemplate, dependencyTemplates) {
16-
const modules = this.renderChunkModules(chunk, moduleTemplate, dependencyTemplates);
17-
const core = this.applyPluginsWaterfall("modules", modules, chunk, moduleTemplate, dependencyTemplates);
16+
const moduleSources = this.renderChunkModules(chunk, moduleTemplate, dependencyTemplates);
17+
const core = this.applyPluginsWaterfall("modules", moduleSources, chunk, moduleTemplate, dependencyTemplates);
1818
let source = this.applyPluginsWaterfall("render", core, chunk, moduleTemplate, dependencyTemplates);
1919
if(chunk.hasEntryModule()) {
2020
source = this.applyPluginsWaterfall("render-with-entry", source, chunk);

‎lib/Compiler.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ Compiler.prototype.readRecords = function readRecords(callback) {
391391
if(err) return callback(err);
392392

393393
try {
394-
self.records = JSON.parse(content);
394+
self.records = JSON.parse(content.toString("utf-8"));
395395
} catch(e) {
396396
e.message = "Cannot parse records: " + e.message;
397397
return callback(e);

‎lib/SetVarMainTemplatePlugin.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class SetVarMainTemplatePlugin {
2626
return new ConcatSource(prefix, source);
2727
}
2828
});
29-
mainTemplate.plugin("global-hash-paths", function(paths) {
29+
mainTemplate.plugin("global-hash-paths", (paths) => {
3030
if(this.varExpression) paths.push(this.varExpression);
3131
return paths;
3232
});

‎lib/dependencies/AMDPlugin.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ class AMDPlugin {
6161
if(typeof parserOptions.amd !== "undefined" && !parserOptions.amd)
6262
return;
6363

64-
function setExpressionToModule(expr, module) {
65-
parser.plugin("expression " + expr, (expr) => {
64+
function setExpressionToModule(outerExpr, module) {
65+
parser.plugin("expression " + outerExpr, (expr) => {
6666
const dep = new AMDRequireItemDependency(module, expr.range);
67-
dep.userRequest = expr;
67+
dep.userRequest = outerExpr;
6868
dep.loc = expr.loc;
6969
parser.state.current.addDependency(dep);
7070
return true;

‎lib/dependencies/HarmonyExportDependencyParserPlugin.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module.exports = class HarmonyExportDependencyParserPlugin {
2525
dep.loc = Object.create(statement.loc);
2626
dep.loc.index = -1;
2727
parser.state.current.addDependency(dep);
28-
parser.state.lastHarmoryImport = dep;
28+
parser.state.lastHarmonyImport = dep;
2929
return true;
3030
});
3131
parser.plugin("export expression", (statement, expr) => {
@@ -53,7 +53,7 @@ module.exports = class HarmonyExportDependencyParserPlugin {
5353
return true;
5454
});
5555
parser.plugin("export import specifier", (statement, source, id, name, idx) => {
56-
const dep = new HarmonyExportImportedSpecifierDependency(parser.state.module, parser.state.lastHarmoryImport, HarmonyModulesHelpers.getModuleVar(parser.state, source), id, name);
56+
const dep = new HarmonyExportImportedSpecifierDependency(parser.state.module, parser.state.lastHarmonyImport, HarmonyModulesHelpers.getModuleVar(parser.state, source), id, name);
5757
dep.loc = Object.create(statement.loc);
5858
dep.loc.index = idx;
5959
parser.state.current.addDependency(dep);

0 commit comments

Comments
 (0)