Skip to content

Commit 1043b0e

Browse files
committed
Remove will-navigate comment after Electron fix
Electron 8.0.2 and later (which we're now using) resolves this issue with `will-navigate`.
1 parent 6bc79ad commit 1043b0e

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

electron_app/src/webcontents-handler.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -174,18 +174,6 @@ function onEditableContextMenu(ev, params) {
174174

175175
module.exports = (webContents) => {
176176
webContents.on('new-window', onWindowOrNavigate);
177-
// XXX: The below now does absolutely nothing because of
178-
// https://github.com/electron/electron/issues/8841
179-
// Whilst this isn't a security issue since without
180-
// node integration and with the sandbox, it should be
181-
// no worse than opening the site in Chrome, it obviously
182-
// means the user has to restart Riot to make it usable
183-
// again (often unintuitive because it minimises to the
184-
// system tray). We therefore need to be vigilant about
185-
// putting target="_blank" on links in Riot (although
186-
// we should generally be doing this anyway since links
187-
// navigating you away from Riot in the browser is
188-
// also annoying).
189177
webContents.on('will-navigate', onWindowOrNavigate);
190178

191179
webContents.on('context-menu', function(ev, params) {

0 commit comments

Comments
 (0)