Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: InsightSoftwareConsortium/ITKPythonPackage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: InsightSoftwareConsortium/ITKPythonPackage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-5.4
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 6 files changed
  • 3 contributors

Commits on Nov 22, 2025

  1. Configuration menu
    Copy the full SHA
    f091c57 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2026

  1. Configuration menu
    Copy the full SHA
    b698e92 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2026

  1. PERF: Set the default threader to Pool

    Continue to enable TBB support, but change the default threader to Pool.
    
    TBB can exhibit decreased performance in some cases, and it seems that
    more refinement is needed with the number of work units, etc.
    
    See:
    
      https://discourse.itk.org/t/8x-slower-registration-with-itk-elastix-python-api-vs-elastix-cli-minimal-reproducible-example/7736
      InsightSoftwareConsortium/ITKElastix#391
    
    This setting is consistent with the libitk conda-forge build configuration.
    thewtex committed Jun 25, 2026
    Configuration menu
    Copy the full SHA
    4159ac5 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2026

  1. Merge pull request #305 from thewtex/default-thread-pool

    PERF: Set the default threader to Pool
    N-Dekker authored Jun 29, 2026
    Configuration menu
    Copy the full SHA
    2f40f4b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2026

  1. Configuration menu
    Copy the full SHA
    3cf7528 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2026

  1. BUG: Avoid re-extracting the ITK build cache for module dependencies

    When building a module that depends on another ITK module (e.g. RTK
    depends on ITKCudaCommon), the ITK build cache is downloaded and
    extracted once in the parent directory. build-module-deps.sh then
    symlinks the module directory to that cache (ITKPythonPackage ->
    ../ITKPythonPackage) and used to re-run the full download-and-extract
    flow inside the module directory.
    
    Re-extracting in the module directory was problematic for two reasons:
    
    - Redundant: the same cache was just extracted in the parent directory
      with the same arguments, and the module directory writes through the
      symlink into that same shared tree.
    
    - Recent GNU tar (openat2 jailification, e.g. Ubuntu tar
      1.35+dfsg-4ubuntu0.2+) fails with 'Invalid cross-device link' (EXDEV)
      when extracting members under ITKPythonPackage/ because the symlink
      escapes the extraction root.
    
    The module dependency build also registers the module (e.g. CudaCommon)
    into the shared ITK build tree (ITK_DIR) it builds against, so the
    registration must land in the tree the parent build reuses afterwards.
    Building against a module-local copy instead of the shared tree breaks
    serial module dependencies.
    
    Fix: when the parent already holds the extracted cache, build the module
    directly against the shared tree with
    dockcross-manylinux-build-module-wheels.sh, without re-extracting it.
    When no cache is available (standalone use of build-module-deps.sh),
    keep the full download-and-extract-and-build path.
    axel-grc committed Sep 1, 2026
    Configuration menu
    Copy the full SHA
    84c6c7f View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2026

  1. Merge pull request #307 from axel-grc/fix-tar-exdev-symlink-r54

    BUG: Avoid re-extracting the ITK build cache for module dependencies
    thewtex authored Sep 3, 2026
    Configuration menu
    Copy the full SHA
    a3b037d View commit details
    Browse the repository at this point in the history
Loading