Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AuraDevelopmentTeam/MultiPlatformCore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: AuraDevelopmentTeam/MultiPlatformCore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature/JDK-16-support
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 3, 2021

  1. Using burningwave core to allow reflection

    @BrainStone
    BrainStone committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    1373690 View commit details
    Browse the repository at this point in the history

  2. Implement addOpens directly 

    Since we're compiling with JDK 8 and this is JDK 9 code we need to do it with reflections...
    @BrainStone
    BrainStone committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    93a44a7 View commit details
    Browse the repository at this point in the history

  3. Properly handling the case where the java.base module somehow doesn't… 

    … exist
    @BrainStone
    BrainStone committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    e21d4a3 View commit details
    Browse the repository at this point in the history

  4. Use own module, not the generic unnamed one

    @BrainStone
    BrainStone committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    97ac2af View commit details
    Browse the repository at this point in the history

  5. Debug logging!

    @BrainStone
    BrainStone committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    5ca6f9d View commit details
    Browse the repository at this point in the history

  6. Use the proper method to get the name

    @BrainStone
    BrainStone committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    6920764 View commit details
    Browse the repository at this point in the history

  7. Switch call order

    @BrainStone
    BrainStone committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    603706c View commit details
    Browse the repository at this point in the history

  8. Also calling addExports

    @BrainStone
    BrainStone committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    7f4456d View commit details
    Browse the repository at this point in the history

  9. Try it the other way round again

    @BrainStone
    BrainStone committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    d10e571 View commit details
    Browse the repository at this point in the history
Loading